Skip to content

Filter elt.parentNode Google Search app bug #4823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2017
Merged

Filter elt.parentNode Google Search app bug #4823

merged 1 commit into from
Jan 26, 2017

Conversation

benvinegar
Copy link
Contributor

@benvinegar
Copy link
Contributor Author

benvinegar commented Jan 25, 2017 •
edited
Loading

So, this might feel a little broad (what if someone has elt.parentNode that is breaking)? But the offending error string is a Safari-specific string (Google Search app is a wrapper around a Safari web view).

The same error on Chrome/Chromium generates a completely different message:

Uncaught TypeError: Cannot read property 'parentNode' of null

Firefox is also different:

TypeError: elt is null

So, if this became a legit bug, users would definitely see it even with this filter enabled (unless all their users were Safari users).

benvinegar
benvinegar commented Jan 25, 2017
View reviewed changes
tests/sentry/filters/test_browser_extensions.py
@@ -43,6 +43,10 @@ def test_filters_conduit_toolbar(self):
data = self.get_mock_data(exc_value='what does conduitPage even do')
assert self.apply_filter(data)

def test_filters_google_search_app_ios(self):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is probably worthless, but hey.

@benvinegar benvinegar mentioned this pull request Jan 25, 2017
Closed
LewisJEllis
LewisJEllis approved these changes Jan 26, 2017
View reviewed changes
Copy link
Contributor

@LewisJEllis LewisJEllis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense from skimming issue discussion

@benvinegar benvinegar merged commit 1986220 into master Jan 26, 2017
@benvinegar benvinegar deleted the filter-gsa-bug branch January 26, 2017 19:06
@Turbo87
Copy link

Turbo87 commented May 2, 2017 •
edited
Loading

@benvinegar it seems we just hit the issue you described above. We are seeing errors like this now:

TypeError: Cannot read property 'parentNode' of null
  at ? (/)

User-Agent shows up as Mozilla/5.0 (iPad; CPU OS 6_0 like Mac OS X; en-us) AppleWebKit/536.26 (KHTML, like Gecko) Mercury/7.0 Mobile/10A403 Safari/8536.25

@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LewisJEllis LewisJEllis LewisJEllis approved these changes

@dcramer dcramer Awaiting requested review from dcramer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benvinegar @Turbo87 @LewisJEllis