ref(device-contexts): Add function that returns a more detailed desc of a language #26558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priscilawebdev
force-pushed
the
ref/display-lang-of-device-context-in-more-human-form
branch
from
c57eb63 to
e540929
Compare
scttcper
reviewed
Jun 11, 2021
|
|
||
| return languageName; | ||
| } catch (error) { | ||
| Sentry.captureException(error); |
There was a problem hiding this comment.
I'm not familiar with how many browsers have Intl.DisplayNames should we check for it first before logging an exception
There was a problem hiding this comment.
nevermind seems okay https://caniuse.com/mdn-javascript_builtins_intl_displaynames_displaynames
scttcper
approved these changes
Jun 11, 2021
priscilawebdev
deleted the
ref/display-lang-of-device-context-in-more-human-form
branch
BYK
reviewed
Jun 14, 2021
Comment on lines
+73
to
+75
| const [languageAbbreviation, countryAbbreviation] = locale.includes('_') | ||
| ? locale.split('_') | ||
| : locale.split('-'); |
There was a problem hiding this comment.
If you ever get a name like a-b-c, you're gonna be in trouble. Could that happen?
| : locale.split('-'); | ||
|
|
||
| try { | ||
| const languageNames = new (Intl as any).DisplayNames(sentryAppLanguageCode, { |
There was a problem hiding this comment.
Might be good to comment here about the as any cast: microsoft/TypeScript#41338
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #26004