Skip to content

Bug: Crons "Retrieve Check-Ins for a Monitor" path parameters invalid #62717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
macmoritz opened this issue Jan 5, 2024 · 4 comments · Fixed by #63704
Closed

Bug: Crons "Retrieve Check-Ins for a Monitor" path parameters invalid #62717

macmoritz opened this issue Jan 5, 2024 · 4 comments · Fixed by #63704

Comments

@macmoritz
Copy link

Environment

self-hosted (https://develop.sentry.dev/self-hosted/)

Steps to Reproduce

The official API reference of crons (I know, it is in beta) for the endpoint "Retrieve Check-Ins for a Monitor" is not clear.
There are three (3) parameters for the path required, but there are only to placeholders in the url.

This also appears in the openapi json spec (shortened):

    "/api/0/organizations/{organization_slug}/monitors/{monitor_slug}/checkins/": {
      "get": {
        "operationId": "Retrieve Check-Ins for a Monitor",
        "description": "Retrieve a list of check-ins for a monitor",
        "parameters": [
          {
            "in": "path",
            "name": "organization_slug",
            "schema": {
              "type": "string"
            },
            "description": "The slug of the organization the resource belongs to.",
            "required": true
          },
          {
            "in": "path",
            "name": "monitor_slug",
            "schema": {
              "type": "string"
            },
            "description": "The slug of the monitor.",
            "required": true
          },
          {
            "in": "path",
            "name": "checkin_id",
            "schema": {
              "type": "string",
              "format": "uuid"
            },
            "description": "The ID of the check-in.",
            "required": true
          }
        ],

In total view, this is an invalid openapi spec.

Expected Result

Clear documentation and spec.
Multiple solutions:

  1. Make the third parameter available in the URL
  2. Make the third parameter not required (f.e. query parameter)

Actual Result

/

Product Area

APIs

Link

No response

DSN

No response

Version

23.12.1

@getsantry
Copy link
Contributor

getsantry bot commented Jan 5, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Jan 8, 2024

Routing to @getsentry/product-owners-apis for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 2 Jan 8, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Jan 8, 2024

Routing to @getsentry/product-owners-crons for triage ⏲️

@rjo100 rjo100 self-assigned this Jan 8, 2024
@rjo100
Copy link
Contributor

rjo100 commented Jan 8, 2024

Thanks for surfacing this! We're cleaning up our docs as we speak, will let you know when this is updated & please let us know if there's any other issues you catch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
4 participants