Skip to content

Additional HEALTH_CHECK_GLOBS #51439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qqii opened this issue Jun 22, 2023 · 3 comments
Closed

Additional HEALTH_CHECK_GLOBS #51439

qqii opened this issue Jun 22, 2023 · 3 comments
Labels
Product Area: Performance Waiting for: Product Owner

Comments

@qqii
Copy link

qqii commented Jun 22, 2023

Problem Statement

Our health check uses /health-check/ instead of one of the existing globs.

sentry/src/sentry/dynamic_sampling/rules/biases/ignore_health_checks_bias.py

Lines 14 to 22 in e49a813

HEALTH_CHECK_GLOBS = [
"*healthcheck*",
"*healthy*",
"*live*",
"*ready*",
"*heartbeat*",
"*/health",
"*/healthz",
]

Solution Brainstorm

Add additional health check globs (*health-check*). Even better would be to allow us to customise this list.

Product Area

Other
@getsantry
Copy link
Contributor

getsantry bot commented Jun 22, 2023

Assigning to @getsentry/support for routing, due by Thursday, June 22nd at 5:00 pm (sfo). ⏲️

@getsantry getsantry bot moved this to Waiting for: Support in GitHub Issues with 👀 Jun 22, 2023
@getsantry
Copy link
Contributor

getsantry bot commented Jun 22, 2023

Routing to @getsentry/product-owners-performance for triage, due by Monday, June 26th at 12:20 (yyz). ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 Jun 22, 2023
@brentc
Copy link

brentc commented Jun 26, 2023

Hi @qqii thanks for the report. Work is currently being done on inbound filters for health checks. You can comment/follow along here: #46731. Closing this request as a duplicate.

@brentc brentc closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Product Area: Performance Waiting for: Product Owner
Projects
GitHub Issues with 👀
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brentc @qqii @kerenkhatiwada