Skip to content

Commit f639f73

Browse files
ref: use base factories create_environment (#74882)
<!-- Describe your PR here. -->
1 parent a6f413d commit f639f73

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

tests/sentry/api/endpoints/test_group_user_reports.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from functools import cached_property
22

3-
from sentry.models.environment import Environment
43
from sentry.models.userreport import UserReport
54
from sentry.testutils.cases import APITestCase, SnubaTestCase
65
from sentry.testutils.helpers.datetime import before_now, iso_format
@@ -10,8 +9,8 @@ class GroupUserReport(APITestCase, SnubaTestCase):
109
def setUp(self):
1110
super().setUp()
1211
self.project = self.create_project()
13-
self.env1 = self.create_environment(self.project, "production")
14-
self.env2 = self.create_environment(self.project, "staging")
12+
self.env1 = self.create_environment(self.project, name="production")
13+
self.env2 = self.create_environment(self.project, name="staging")
1514

1615
self.env1_events = self.create_events_for_environment(self.env1, 5)
1716
self.env2_events = self.create_events_for_environment(self.env2, 5)
@@ -29,11 +28,6 @@ def setUp(self):
2928
def path(self):
3029
return f"/api/0/groups/{self.group.id}/user-feedback/"
3130

32-
def create_environment(self, project, name):
33-
env = Environment.objects.create(organization_id=project.organization_id, name=name)
34-
env.add_project(project)
35-
return env
36-
3731
def create_events_for_environment(self, environment, num_events):
3832
return [
3933
self.store_event(
@@ -91,7 +85,7 @@ def test_no_environment_does_not_exists(self):
9185
def test_no_environment(self):
9286
self.login_as(user=self.user)
9387

94-
empty_env = self.create_environment(self.project, "")
88+
empty_env = self.create_environment(self.project, name="")
9589
empty_env_events = self.create_events_for_environment(empty_env, 5)
9690
userreports = self.create_user_report_for_events(
9791
self.project, self.group, empty_env_events, empty_env

0 commit comments

Comments
 (0)