Split up multi-action Enhancement rules (#51358)

This properly splits up multi-action enhancement `Rule`s so only
modifier actions are run for modifier rules.

The first half of #51354

Author: Swatinem

src/sentry/grouping/enhancer/__init__.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 import base64
 import os
 import zlib
@@ -113,8 +115,13 @@ def __init__(self, rules, version=None, bases=None, id=None):
             bases = []
         self.bases = bases
 
-        self._modifier_rules = [rule for rule in self.iter_rules() if rule.is_modifier]
-        self._updater_rules = [rule for rule in self.iter_rules() if rule.is_updater]
+        self._modifier_rules = []
+        self._updater_rules = []
+        for rule in self.iter_rules():
+            if modifier_rule := rule._as_modifier_rule():
+                self._modifier_rules.append(modifier_rule)
+            if updater_rule := rule._as_updater_rule():
+                self._updater_rules.append(updater_rule)
 
     def apply_modifications_to_frame(self, frames, platform, exception_data):
         """This applies the frame modifications to the frames itself.  This
@@ -296,15 +303,15 @@ def matcher_description(self):
             rv = f"{rv} {action}"
         return rv
 
-    @property
-    def is_modifier(self):
-        """Does this rule modify the frame?"""
-        return self._is_modifier
+    def _as_modifier_rule(self) -> Rule | None:
+        actions = [action for action in self.actions if action.is_modifier]
+        if actions:
+            return Rule(self.matchers, actions)
 
-    @property
-    def is_updater(self):
-        """Does this rule update grouping components?"""
-        return self._is_updater
+    def _as_updater_rule(self) -> Rule | None:
+        actions = [action for action in self.actions if action.is_updater]
+        if actions:
+            return Rule(self.matchers, actions)
 
     def as_dict(self):
         matchers = {}

src/sentry/grouping/enhancer/actions.py

@@ -90,9 +90,6 @@ def _in_app_changed(self, frame, component):
             return self.flag == component.contributes
 
     def apply_modifications_to_frame(self, frames, match_frames, idx, rule=None):
-        # Grouping is not stored on the frame
-        if self.key == "group":
-            return
         if self.key == "app":
             for frame, match_frame in self._slice_to_range(list(zip(frames, match_frames)), idx):
                 set_in_app(frame, self.flag)