Skip to content

Upgrade to tokio 1.0 and reqwest 0.11 #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2021
Merged

Conversation

jtgeibel
Copy link
Contributor

@jtgeibel jtgeibel commented Jan 5, 2021

This upgrades sentry-core and sentry to the new releases. sentry-actix is still based on tokio 0.2. The MSRV is bumped to 1.45.0.

This upgrades `sentry-core` and `sentry` to the new releases.
`sentry-actix` is still based on `tokio 0.2`
@jtgeibel
Copy link
Contributor Author

jtgeibel commented Jan 5, 2021

The test failure is because tokio has bumped it's minimum supported rustc to 1.45. Their release announcement describes their MSRV as:

Tokio will keep a rolling MSRV (minimum supported rust version) policy of 6 months. When increasing the MSRV, the new Rust version must have been released at least six months ago.

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentry-core/src/futures.rs#L77:
variable does not need to be mutable

Other than that, I’m +1 on this. I will run the MSRV requirement by the team just in case.

@Swatinem
Copy link
Member

Swatinem commented Jan 6, 2021

I will run the MSRV requirement by the team just in case.

@jtgeibel go ahead! Please update the CI job, and adjust the README files accordingly.

@jtgeibel
Copy link
Contributor Author

jtgeibel commented Jan 7, 2021

Sounds great @Swatinem! I've bumped the MSRV and fixed the warning.

@Swatinem Swatinem merged commit 7eb31e3 into getsentry:master Jan 7, 2021
bors added a commit to rust-lang/crates.io that referenced this pull request Jan 14, 2021
Bump to `tokio 1.0` and `hyper 0.14`

To avoid pulling in 2 versions of `tokio` at once:

* [x] Await `hyper-tls 0.5`
* [x] Await `reqwest 0.11`
* [x] Await an `oauth2` release depending on `reqwest 0.11` - ramosbugs/oauth2-rs#118
* [x] Await a `sentry` release depending on `reqwest 0.11` - getsentry/sentry-rust#304

r? `@ghost`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants