Skip to content

fix(xcode): Upload debug-files needs a path to read from #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix(xcode): Upload debug-files needs a path to read from #2913

merged 2 commits into from
Mar 22, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Mar 22, 2023 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

since sentry-cli v2

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@krystofwoldrich krystofwoldrich mentioned this pull request Mar 22, 2023
Closed
@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 349.39 ms 364.98 ms 15.59 ms
Size 17.73 MiB 20.06 MiB 2.32 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms

App size

Revision Plain With Sentry Diff
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1261.38 ms 1263.96 ms 2.58 ms
Size 2.36 MiB 2.83 MiB 479.25 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms

App size

Revision Plain With Sentry Diff
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 362.96 ms 415.55 ms 52.59 ms
Size 7.15 MiB 8.10 MiB 977.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms

App size

Revision Plain With Sentry Diff
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1240.65 ms 1258.38 ms 17.73 ms
Size 2.92 MiB 3.39 MiB 486.03 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9a3ca65+dirty 1276.40 ms 1279.14 ms 2.74 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms

App size

Revision Plain With Sentry Diff
9a3ca65+dirty 2.92 MiB 3.37 MiB 464.32 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) March 22, 2023 13:31
@krystofwoldrich krystofwoldrich merged commit 8900e1a into main Mar 22, 2023
@krystofwoldrich krystofwoldrich deleted the kw-fix-xcode-debug-files-upload branch March 22, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @marandaneto