feat: Send envelopes to the envelope endpoint #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhcarvalho
reviewed
Jun 23, 2020
rhcarvalho
reviewed
Jun 23, 2020
| @@ -172,7 +173,10 @@ def _send_request( | |||
| } | |||
| ) | |||
| response = self._pool.request( | |||
| "POST", str(self._auth.store_api_url), body=body, headers=headers | |||
| "POST", | |||
| str(self._auth.get_api_url(endpoint_type)), | |||
There was a problem hiding this comment.
Suggested change
| str(self._auth.get_api_url(endpoint_type)), | |
| self._auth.get_api_url(endpoint_type), |
Why do we need str here? If we need some Py2/3 compatibility and requests limits what it takes, we could handle this in get_api_url itself, otherwise all callers would need to make adjustments (and this seems to be the only caller other than test code).
While we don't consider Auth to be part of the public API, the contract is not very clear. This change is to prevent unnecessarily breaking downstream uses of the Auth.store_api_url property. Since we don't have any existing use of Python's DeprecationWarning, nor any other system in place to communicate deprecation, we start with just a note in the docstring.
untitaker
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.