Skip to content

Fix custom model name #4569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

Fix custom model name #4569

merged 1 commit into from
Jul 10, 2025

Conversation

antonpirker
Copy link
Member

The model parameter can be a string or an object of the model itself. If it is a model, get the models name from the .model attribute.

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.73%. Comparing base (5709b25) to head (5808bec).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4569   +/-   ##
=======================================
  Coverage   80.72%   80.73%           
=======================================
  Files         156      156           
  Lines       16481    16483    +2     
  Branches     2801     2801           
=======================================
+ Hits        13304    13307    +3     
- Misses       2295     2296    +1     
+ Partials      882      880    -2     
Files with missing lines Coverage Δ
..._sdk/integrations/openai_agents/spans/ai_client.py 83.33% <100.00%> (+0.98%) ⬆️
sentry_sdk/integrations/openai_agents/utils.py 72.80% <100.00%> (+0.24%) ⬆️

... and 4 files with indirect coverage changes

@antonpirker antonpirker marked this pull request as ready for review July 10, 2025 09:38
@antonpirker antonpirker requested a review from a team as a code owner July 10, 2025 09:38
@antonpirker antonpirker merged commit 1df6c9a into master Jul 10, 2025
150 of 152 checks passed
@antonpirker antonpirker deleted the antonpirker/fix-model-name branch July 10, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants