feat(scope): Remove client parameter
#4449
Merged
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use the `client` parameter in the `Scope`'s constructor, perhaps we can remove it and simplify the API. It is still possible to set the client with `Scope.set_client`. BREAKING CHANGE: `sentry_sdk.Scope` no longer has a `client` parameter.
szokeasaurusrex
requested review from
antonpirker and
sentrivana
and removed request for
a team
szokeasaurusrex
commented
Jun 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## potel-base #4449 +/- ##
==============================================
- Coverage 84.80% 84.79% -0.02%
==============================================
Files 144 144
Lines 14725 14728 +3
Branches 2343 2343
==============================================
Hits 12488 12488
Misses 1523 1523
- Partials 714 717 +3
|
sl0thentr0py
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use the
clientparameter in theScope's constructor, perhaps we can remove it and simplify the API. It is still possible to set the client withScope.set_client.BREAKING CHANGE:
sentry_sdk.Scopeno longer has aclientparameter.Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval.