Remove scope.span = setter and make sure scope.span reference is correct in context manager regardless of source of span
#4439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
commented
Jun 3, 2025
| @@ -280,10 +279,6 @@ def __enter__(self): | |||
| # set as the implicit current context | |||
| self._ctx_token = context.attach(ctx) | |||
|
|
|||
| # get the new scope that was forked on context.attach | |||
There was a problem hiding this comment.
this is now done universally in the context manager instead of here which would just affect the sentry created spans
sl0thentr0py
commented
Jun 3, 2025
| rust_tracing.new_span(RustTracingLevel.Info, 3) | ||
| current_span = sentry_sdk.get_current_span() | ||
| assert current_span is not None |
There was a problem hiding this comment.
this was just INVALID_SPAN before so this test wasn't correct anyway
sl0thentr0py
force-pushed
the
neel/remove-scope-span-setter
branch
from
f01cb0f to
605a673
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## potel-base #4439 +/- ##
==============================================
- Coverage 84.81% 84.80% -0.02%
==============================================
Files 144 144
Lines 14726 14725 -1
Branches 2342 2343 +1
==============================================
- Hits 12490 12487 -3
Misses 1523 1523
- Partials 713 715 +2
|
sentrivana
approved these changes
Jun 3, 2025
sl0thentr0py
force-pushed
the
neel/remove-scope-span-setter
branch
from
605a673 to
32ec148
Compare
correct in context manager regardless of source of span.
sl0thentr0py
force-pushed
the
neel/remove-scope-span-setter
branch
from
32ec148 to
5dba74b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3509