Skip to content

Add add_attachment() top level API #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented May 5, 2025

Users should not need to get the Scope and add the attachment there, we can do it for them. This has been first implemented in SDK 3.0 and is now back ported to 2.x.

Copy link

codecov bot commented May 5, 2025

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
23568 6 23562 5866
View the top 3 failed test(s) by shortest run time
tests.integrations.redis.cluster.test_redis_cluster test_rediscluster_pipeline[False-expected_first_ten0]
Stack Traces | 0.086s run time
.../redis/cluster/test_redis_cluster.py:121: in test_rediscluster_pipeline
    pipeline = rc.pipeline()
.../redis/cluster/test_redis_cluster.py:16: in <lambda>
    redis.RedisCluster.pipeline = lambda *_, **__: pipeline_cls(None, None)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/utils.py:188: in wrapper
    return func(*args, **kwargs)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/cluster.py:2125: in __init__
    retries=self.cluster_error_retry_attempts,
E   AttributeError: 'ClusterPipeline' object has no attribute 'cluster_error_retry_attempts'
tests.integrations.redis.cluster.test_redis_cluster test_rediscluster_pipeline[True-expected_first_ten1]
Stack Traces | 0.087s run time
.../redis/cluster/test_redis_cluster.py:121: in test_rediscluster_pipeline
    pipeline = rc.pipeline()
.../redis/cluster/test_redis_cluster.py:16: in <lambda>
    redis.RedisCluster.pipeline = lambda *_, **__: pipeline_cls(None, None)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/utils.py:188: in wrapper
    return func(*args, **kwargs)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/cluster.py:2125: in __init__
    retries=self.cluster_error_retry_attempts,
E   AttributeError: 'ClusterPipeline' object has no attribute 'cluster_error_retry_attempts'
tests.integrations.redis.cluster.test_redis_cluster test_rediscluster_span_origin
Stack Traces | 0.087s run time
.../redis/cluster/test_redis_cluster.py:162: in test_rediscluster_span_origin
    pipeline = rc.pipeline(transaction=False)
.../redis/cluster/test_redis_cluster.py:16: in <lambda>
    redis.RedisCluster.pipeline = lambda *_, **__: pipeline_cls(None, None)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/utils.py:188: in wrapper
    return func(*args, **kwargs)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/cluster.py:2125: in __init__
    retries=self.cluster_error_retry_attempts,
E   AttributeError: 'ClusterPipeline' object has no attribute 'cluster_error_retry_attempts'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@antonpirker antonpirker marked this pull request as ready for review May 5, 2025 14:35
@antonpirker antonpirker requested a review from a team as a code owner May 5, 2025 14:35
@sl0thentr0py sl0thentr0py changed the base branch from master to antonpirker/put-feature-flags-on-isolation-scope May 5, 2025 14:43
@antonpirker antonpirker merged commit e635af7 into antonpirker/put-feature-flags-on-isolation-scope May 5, 2025
133 of 136 checks passed
@antonpirker antonpirker deleted the antonpirker/add-attachment-top-level-api branch May 5, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants