fix(starlette): Fix failed_request_status_codes=[]

Passing an empty list for `failed_request_status_codes` should result in no status codes resulting in a Sentry error. However, right now, setting `failed_request_status_codes=[]` instead yields the default `failed_request_status_codes` of `range(500, 599)`. This change fixes the incorrect behavior and adds tests to verify the fix.

Author: szokeasaurusrex

sentry_sdk/integrations/starlette.py

@@ -88,9 +88,11 @@ def __init__(
             )
         self.transaction_style = transaction_style
         self.middleware_spans = middleware_spans
-        self.failed_request_status_codes = failed_request_status_codes or [
-            range(500, 599)
-        ]
+        self.failed_request_status_codes = (
+            [range(500, 599)]
+            if failed_request_status_codes is None
+            else failed_request_status_codes
+        )
 
     @staticmethod
     def setup_once():

tests/integrations/fastapi/test_fastapi.py

@@ -519,6 +519,7 @@ def test_transaction_name_in_middleware(
         ([range(400, 403), 500, 501], 405, False),
         ([range(400, 403), 500, 501], 501, True),
         ([range(400, 403), 500, 501], 503, False),
+        ([], 500, False),
     ],
 )
 def test_configurable_status_codes(

tests/integrations/starlette/test_starlette.py

@@ -1149,6 +1149,7 @@ def test_span_origin(sentry_init, capture_events):
         ([range(400, 403), 500, 501], 405, False),
         ([range(400, 403), 500, 501], 501, True),
         ([range(400, 403), 500, 501], 503, False),
+        ([], 500, False),
     ],
 )
 def test_configurable_status_codes(