Skip to content

Commit 5f7df61

Browse files
committed
test: Allow passing of PostgreSQL port
In some environments, port `5432` might be already opened by some other process the testing process. Allow passing an arbitrary port via the `SENTPY_PYTHON_TEST_POSTGRES_PORT` environmental variable.
1 parent 06d5da1 commit 5f7df61

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

tests/integrations/asyncpg/test_asyncpg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414

1515
PG_HOST = os.getenv("SENTRY_PYTHON_TEST_POSTGRES_HOST", "localhost")
16-
PG_PORT = 5432
16+
PG_PORT = int(os.getenv("SENTRY_PYTHON_TEST_POSTGRES_PORT", "5432"))
1717
PG_USER = os.getenv("SENTRY_PYTHON_TEST_POSTGRES_USER", "postgres")
1818
PG_PASSWORD = os.getenv("SENTRY_PYTHON_TEST_POSTGRES_PASSWORD", "sentry")
1919
PG_NAME = os.getenv("SENTRY_PYTHON_TEST_POSTGRES_NAME", "postgres")

tests/integrations/django/myapp/settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def middleware(request):
122122
DATABASES["postgres"] = {
123123
"ENGINE": db_engine,
124124
"HOST": os.environ.get("SENTRY_PYTHON_TEST_POSTGRES_HOST", "localhost"),
125-
"PORT": 5432,
125+
"PORT": int(os.environ.get("SENTRY_PYTHON_TEST_POSTGRES_PORT", "5432")),
126126
"USER": os.environ.get("SENTRY_PYTHON_TEST_POSTGRES_USER", "postgres"),
127127
"PASSWORD": os.environ.get("SENTRY_PYTHON_TEST_POSTGRES_PASSWORD", "sentry"),
128128
"NAME": os.environ.get(

tests/integrations/django/test_basic.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,9 @@ def test_db_connection_span_data(sentry_init, client, capture_events):
626626
assert data.get(SPANDATA.SERVER_ADDRESS) == os.environ.get(
627627
"SENTRY_PYTHON_TEST_POSTGRES_HOST", "localhost"
628628
)
629-
assert data.get(SPANDATA.SERVER_PORT) == "5432"
629+
assert data.get(SPANDATA.SERVER_PORT) == os.environ.get(
630+
"SENTRY_PYTHON_TEST_POSTGRES_PORT", "5432"
631+
)
630632

631633

632634
def test_set_db_data_custom_backend():

0 commit comments

Comments
 (0)