feat(pymongo): Set MongoDB tags directly on span data (#3290)

* feat(pymongo): Set MongoDB tags directly on span data

Co-authored-by: Daniel Szoke <[email protected]>

---------

Co-authored-by: Daniel Szoke <[email protected]>

Author: 0Calories

sentry_sdk/integrations/pymongo.py

@@ -163,8 +163,12 @@ def started(self, event):
             )
 
             for tag, value in tags.items():
+                # set the tag for backwards-compatibility.
+                # TODO: remove the set_tag call in the next major release!
                 span.set_tag(tag, value)
 
+                span.set_data(tag, value)
+
             for key, value in data.items():
                 span.set_data(key, value)
 

tests/integrations/pymongo/test_pymongo.py

@@ -62,21 +62,28 @@ def test_transactions(sentry_init, capture_events, mongo_server, with_pii):
         assert span["data"][SPANDATA.SERVER_PORT] == mongo_server.port
         for field, value in common_tags.items():
             assert span["tags"][field] == value
+            assert span["data"][field] == value
 
     assert find["op"] == "db"
     assert insert_success["op"] == "db"
     assert insert_fail["op"] == "db"
 
+    assert find["data"]["db.operation"] == "find"
     assert find["tags"]["db.operation"] == "find"
+    assert insert_success["data"]["db.operation"] == "insert"
     assert insert_success["tags"]["db.operation"] == "insert"
+    assert insert_fail["data"]["db.operation"] == "insert"
     assert insert_fail["tags"]["db.operation"] == "insert"
 
     assert find["description"].startswith('{"find')
     assert insert_success["description"].startswith('{"insert')
     assert insert_fail["description"].startswith('{"insert')
 
+    assert find["data"][SPANDATA.DB_MONGODB_COLLECTION] == "test_collection"
     assert find["tags"][SPANDATA.DB_MONGODB_COLLECTION] == "test_collection"
+    assert insert_success["data"][SPANDATA.DB_MONGODB_COLLECTION] == "test_collection"
     assert insert_success["tags"][SPANDATA.DB_MONGODB_COLLECTION] == "test_collection"
+    assert insert_fail["data"][SPANDATA.DB_MONGODB_COLLECTION] == "erroneous"
     assert insert_fail["tags"][SPANDATA.DB_MONGODB_COLLECTION] == "erroneous"
     if with_pii:
         assert "1" in find["description"]