Skip to content

feat(replay): Change to use preset quality values #9903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions packages/replay/src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,33 @@ export const MAX_REPLAY_DURATION = 3_600_000; // 60 minutes in ms;

/** Default attributes to be ignored when `maskAllText` is enabled */
export const DEFAULT_IGNORED_ATTRIBUTES = ['title', 'placeholder'];

export const CANVAS_QUALITY = {
low: {
sampling: {
canvas: 1,
},
dataURLOptions: {
type: 'image/webp',
quality: 0.25,
},
},
medium: {
sampling: {
canvas: 2,
},
dataURLOptions: {
type: 'image/webp',
quality: 0.4,
},
},
high: {
sampling: {
canvas: 4,
},
dataURLOptions: {
type: 'image/webp',
quality: 0.5,
},
},
};
16 changes: 7 additions & 9 deletions packages/replay/src/replay.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { logger } from '@sentry/utils';

import {
BUFFER_CHECKOUT_TIME,
CANVAS_QUALITY,
SESSION_IDLE_EXPIRE_DURATION,
SESSION_IDLE_PAUSE_DURATION,
SLOW_CLICK_SCROLL_TIMEOUT,
Expand Down Expand Up @@ -340,15 +341,12 @@ export class ReplayContainer implements ReplayContainerInterface {
...(this.recordingMode === 'buffer' && { checkoutEveryNms: BUFFER_CHECKOUT_TIME }),
emit: getHandleRecordingEmit(this),
onMutation: this._onMutationHandler,
...(canvas && {
recordCanvas: true,
sampling: { canvas: canvas.fps || 4 },
dataURLOptions: {
type: canvas.type || 'image/webp',
quality: canvas.quality || 0.6,
},
getCanvasManager: canvas.manager,
}),
...(canvas &&
canvas.manager && {
recordCanvas: true,
getCanvasManager: canvas.manager,
...(CANVAS_QUALITY[canvas.quality || 'medium'] || CANVAS_QUALITY.medium),
}),
});
} catch (err) {
this._handleException(err);
Expand Down
4 changes: 1 addition & 3 deletions packages/replay/src/types/replay.ts
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,7 @@ export interface ReplayPluginOptions extends ReplayNetworkOptions {
captureExceptions: boolean;
traceInternals: boolean;
canvas: {
fps?: number;
quality?: number;
type?: string;
quality?: 'low' | 'medium' | 'high';
manager: (options: GetCanvasManagerOptions) => CanvasManagerInterface;
};
}>;
Expand Down
30 changes: 30 additions & 0 deletions packages/replay/test/integration/rrweb.test.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { CanvasManagerInterface } from '../../src/types';
import { resetSdkMock } from '../mocks/resetSdkMock';
import { useFakeTimers } from '../utils/use-fake-timers';

Expand Down Expand Up @@ -40,4 +41,33 @@ describe('Integration | rrweb', () => {
}
`);
});

it('calls rrweb.record with default canvas options', async () => {
const { mockRecord } = await resetSdkMock({
replayOptions: {
_experiments: {
canvas: {
// @ts-expect-error This should return
// CanvasManagerInterface, but we don't care about it
// for this test
manager: () => null,
},
},
},
});

expect(mockRecord).toHaveBeenLastCalledWith(
expect.objectContaining({
recordCanvas: true,
getCanvasManager: expect.any(Function),
dataURLOptions: {
quality: 0.4,
type: 'image/webp',
},
sampling: {
canvas: 2,
},
}),
);
});
});