-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(node): Add abnormal session support for ANR #9268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Add abnormal session support for ANR #9268
Conversation
After the session hits a terminal state it cannot be updated anymore, so I think we are fine. |
Sorry for chiming in, this is correct^, but this should be enforced client-side iirc. On the server we can't really do that, because we have aggregates and don't keep reference on a single session, so there's no way to know whether it was terminated already when a new update comes in. We've already faced this on Android once, when were sending multiple |
Also, note that it's currently hardcoded for android-only and behind a feature flag, we'd have to relax those conditions (maybe even remove the flag altogether, it's been out for almost a year, but need to check with @shruthilayaj) |
I've modified this PR so the ANR child process now notifies the main process that an ANR has been triggered and we clear any session from the scope. This is probably not completely foolproof since we may have lost contact with the main process. |
This PR:
abnormal_mechanism
property to session typesThis PR makes no attempt to suppress further session updates from the main app process.How does Sentry backend treat conflicting session updates?Ref: getsentry/sentry-electron#774