build: Update size-limit to 9.0.0 to fix Node 18 compatibility #9261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
requested review from
stephanie-anderson and
Lms24
and removed request for
a team
lforst
approved these changes
Oct 16, 2023
| @@ -118,7 +118,7 @@ | |||
| "rollup-plugin-license": "^2.6.1", | |||
| "rollup-plugin-terser": "^7.0.2", | |||
| "sinon": "^7.3.2", | |||
| "size-limit": "^4.5.5", | |||
| "size-limit": "~9.0.0", | |||
There was a problem hiding this comment.
I tend to prefer stricter pinning (in reality it doesn't matter, we could even exact pin it as it shouldn't change). But 🤷
size-limit report 📦
|
Yeah numbers are slightly different, I guess we'll just have a slightly shifted new baseline! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed that running
yarn size-limitlocally is failing, due to old versions being incompatible with Node 18. So bumping this to the latest version, which also uses webpack 5 instead of 4 under the hood.