Skip to content

revert: Expose sampleTransaction export from core #9208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 10, 2023

This was previously exported so we can use it in node-experimental, but turns out we can't do that anyhow because we need to sample in OTEL. This has not yet been released, so in order to avoid exporting stuff we don't need public let's revert this export. (I'll leave the actual restructuring of moving this into a dedicated file in, though, because I think it still makes sense that way).

@mydea mydea self-assigned this Oct 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 84.25 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.41 KB (0%)
@sentry/browser - Webpack (gzipped) 22 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 78.78 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.6 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.01 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 254.47 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.75 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 62.44 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.46 KB (-0.01% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 84.28 KB (+0.04% 🔺)
@sentry/react - Webpack (gzipped) 22.05 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 102.2 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.95 KB (-0.07% 🔽)

@mydea mydea force-pushed the fn/remove-sampleTransaction-export branch from 5f09844 to 87b0884 Compare October 11, 2023 08:53
@mydea mydea marked this pull request as ready for review October 11, 2023 08:53
@mydea mydea requested a review from lforst October 11, 2023 08:53
This was previously exported so we can use it in node-experimental, but turns out we can't do that anyhow because we need to sample in OTEL. This has not yet been released, so in order to avoid exporting stuff we don't need public let's revert this export. (I'll leave the actual restructuring of moving this into a dedicated file in, though, because I think it still makes sense that way)
@mydea mydea force-pushed the fn/remove-sampleTransaction-export branch from 87b0884 to c98eb8a Compare October 11, 2023 10:52
@mydea mydea merged commit bde088e into develop Oct 11, 2023
@mydea mydea deleted the fn/remove-sampleTransaction-export branch October 11, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants