fix(remix): Use React.ComponentType instead of React.FC as withSentry's generic type.
#9043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use generic that encapsulates all component types
onurtemizkan
changed the title
React.ComponentType instead of React.FC as withSentry's generic type.
Lms24
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Thanks for contributing @lifeiscontent!
Just FYI, we open our PRs against the develop branch instead of master as we're (mostly) following git-flow. No problem though, I changed the target :)
|
@lifeiscontent if you rebase we can merge the PR in! |
|
Actually it seems I could rebase - going to merge on my end. Thanks for the PR! |
|
Fix was released with with https://github.com/getsentry/sentry-javascript/releases/tag/7.70.0. Thanks for your contribution @lifeiscontent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use generic that encapsulates all component types
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).