fix(nextjs): Inject init code via relative path #8135
Conversation
| @@ -79,6 +79,8 @@ export default function wrappingLoader( | |||
| vercelCronsConfig, | |||
| } = 'getOptions' in this ? this.getOptions() : this.query; | |||
|
|
|||
| this.resourcePath; | |||
size-limit report 📦
|
| templateCode = `import "${sentryConfigFilePath}";`.concat(templateCode); | ||
| if (sentryConfigFilePath && path.isAbsolute(this.resourcePath)) { | ||
| const sentryConfigFileImportPath = path | ||
| .relative(this.resourcePath, sentryConfigFilePath) // Get path relative to current module because webpack can't handle absolute paths on windows: https://github.com/getsentry/sentry-javascript/issues/8133 |
There was a problem hiding this comment.
This needs to be path.dirname(this.resourcePath) otherwise the relative path goes up one level too far
There was a problem hiding this comment.
Yea that seems to be the most important thing!
| @@ -202,8 +202,13 @@ export default function wrappingLoader( | |||
| templateCode = templateCode.replace(/__COMPONENT_TYPE__/g, 'Unknown'); | |||
| } | |||
|
|
|||
| if (sentryConfigFilePath) { | |||
| templateCode = `import "${sentryConfigFilePath}";`.concat(templateCode); | |||
| if (sentryConfigFilePath && path.isAbsolute(this.resourcePath)) { | |||
There was a problem hiding this comment.
Why the check here for isAbsolute?
There was a problem hiding this comment.
I don't think webpack really defines what the value behind this looks like. Usually it is an absolute path but I think it could also be some virtual module and stuff and we can't create relative imports for virtual modules so it is just a check for the cases we can actually handle. Does this make sense?
| if (sentryConfigFilePath && path.isAbsolute(this.resourcePath)) { | ||
| const sentryConfigFileImportPath = path | ||
| .relative(this.resourcePath, sentryConfigFilePath) // Get path relative to current module because webpack can't handle absolute paths on windows: https://github.com/getsentry/sentry-javascript/issues/8133 | ||
| .replace(/\.[^/.]+$/, ''); // Remove the file extension from the import |
There was a problem hiding this comment.
You also need to replace every \ with /. Import paths cannot use backslashes?
There was a problem hiding this comment.
It's worth noting that in my testing, the file extension didn't seem to matter!
There was a problem hiding this comment.
Ah thanks for pointing that out. Was just messing around here and yeah doesn't seem to fix anything haha
Potentially fixes #8133