Skip to content

ref(tracing): Re-add BrowserTracing static ID #7721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 4, 2023

This was removed in #5166 due to tree shaking concerns, however we have had a static ID for replay and it has been working fine so far.

This was removed in #5166 due to tree shaking concerns, however we have had a static ID for replay and it has been working fine so far.
@mydea mydea requested review from lforst, Lms24 and AbhiPrasad April 4, 2023 08:26
@mydea mydea self-assigned this Apr 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.77 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 64.88 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 57.2 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.63 KB (+3.83% 🔺)
@sentry/browser - Webpack (minified) 72.41 KB (+6.23% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.65 KB (+3.8% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.08 KB (+6.99% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.36 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.54 KB (+0.05% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.87 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.86 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.6 KB (+0.04% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.62 KB (0%)

@mydea
Copy link
Member Author

mydea commented Apr 4, 2023

OK, seems this is still relevant... worth exploring why this is the case, but closing this for now!

@mydea mydea closed this Apr 4, 2023
@mydea mydea deleted the fn/browsertracing-id branch May 28, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant