meta: Update CHANGELOG for 7.44.0

.craft.yml

@@ -11,6 +11,8 @@ targets:
           - nodejs10.x
           - nodejs12.x
           - nodejs14.x
+          - nodejs16.x
+          - nodejs18.x
     license: MIT
   - name: gcs
     includeNames: /.*\.js.*$/
@@ -22,7 +24,6 @@ targets:
   - name: github
     includeNames: /^sentry-.*$/
   - name: npm
-    excludeNames: /^sentry-sveltekit-.*$/
   - name: registry
     sdks:
       'npm:@sentry/browser':

.git-blame-ignore-revs

@@ -6,3 +6,6 @@
 
 #  build: Add `@typescript-eslint/consistent-type-imports` rule (#6662)
 2aa4e94b036675245290596884959e06dcced044
+
+# chore: Rename `integration-tests` -> `browser-integration-tests` (#7455)
+ef6b3c7877d5fc8031c08bb28b0ffafaeb01f501

.github/workflows/build.yml

@@ -99,7 +99,7 @@ jobs:
             browser_integration:
               - *shared
               - *browser
-              - 'packages/integration-tests/**'
+              - 'packages/browser-integration-tests/**'
             ember:
               - *shared
               - *browser
@@ -144,7 +144,8 @@ jobs:
       has_gitflow_label:
         ${{ github.event_name == 'pull_request' && contains(steps.pr-labels.outputs.labels, ' Gitflow ') }}
       force_skip_cache:
-        ${{ github.event_name == 'schedule' || (github.event_name == 'pull_request' && contains(steps.pr-labels.outputs.labels, ' ci-skip-cache ')) }}
+        ${{ github.event_name == 'schedule' || (github.event_name == 'pull_request' &&
+        contains(steps.pr-labels.outputs.labels, ' ci-skip-cache ')) }}
 
   job_install_deps:
     name: Install Dependencies
@@ -274,7 +275,9 @@ jobs:
     needs: [job_get_metadata, job_build]
     timeout-minutes: 15
     runs-on: ubuntu-20.04
-    if: github.event_name == 'pull_request' || needs.job_get_metadata.outputs.is_develop == 'true' || needs.job_get_metadata.outputs.is_release == 'true'
+    if:
+      github.event_name == 'pull_request' || needs.job_get_metadata.outputs.is_develop == 'true' ||
+      needs.job_get_metadata.outputs.is_release == 'true'
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
         uses: actions/checkout@v3
@@ -540,7 +543,7 @@ jobs:
           PW_BUNDLE: ${{ matrix.bundle }}
           PW_TRACING_ONLY: ${{ matrix.tracing_only }}
         run: |
-          cd packages/integration-tests
+          cd packages/browser-integration-tests
           yarn test:ci
 
   job_browser_integration_tests:

.github/workflows/flaky-test-detector.yml

@@ -0,0 +1,81 @@
+name: 'Detect flaky tests'
+on:
+  workflow_dispatch:
+  pull_request:
+    paths:
+      - 'packages/browser-integration-tests/suites/**'
+
+env:
+  HEAD_COMMIT: ${{ github.event.inputs.commit || github.sha }}
+
+  NX_CACHE_RESTORE_KEYS: |
+    nx-Linux-${{ github.ref }}-${{ github.event.inputs.commit || github.sha }}
+    nx-Linux-${{ github.ref }}
+    nx-Linux
+
+# Cancel in progress workflows on pull_requests.
+# https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  flaky-detector:
+    runs-on: ubuntu-20.04
+    timeout-minutes: 60
+    name: 'Check tests for flakiness'
+    steps:
+      - name: Check out current branch
+        uses: actions/checkout@v3
+      - name: Set up Node
+        uses: volta-cli/action@v4
+
+      - name: Install dependencies
+        run: yarn install --ignore-engines --frozen-lockfile
+
+      - name: NX cache
+        uses: actions/cache/restore@v3
+        with:
+          path: .nxcache
+          key: nx-Linux-${{ github.ref }}-${{ env.HEAD_COMMIT }}
+          restore-keys: ${{ env.NX_CACHE_RESTORE_KEYS }}
+
+      - name: Build packages
+        run: yarn build
+
+      - name: Get npm cache directory
+        id: npm-cache-dir
+        run: echo "dir=$(npm config get cache)" >> $GITHUB_OUTPUT
+      - name: Get Playwright version
+        id: playwright-version
+        run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> $GITHUB_OUTPUT
+      - uses: actions/cache@v3
+        name: Check if Playwright browser is cached
+        id: playwright-cache
+        with:
+          path: ${{ steps.npm-cache-dir.outputs.dir }}
+          key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
+      - name: Install Playwright browser if not cached
+        if: steps.playwright-cache.outputs.cache-hit != 'true'
+        run: npx playwright install --with-deps
+        env:
+          PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
+      - name: Install OS dependencies of Playwright if cache hit
+        if: steps.playwright-cache.outputs.cache-hit == 'true'
+        run: npx playwright install-deps
+
+      - name: Determine changed tests
+        uses: getsentry/[email protected]
+        id: changed
+        with:
+          list-files: json
+          filters: |
+            browser_integration: packages/browser-integration-tests/suites/**
+
+      - name: Detect flaky tests
+        run: yarn test:detect-flaky
+        working-directory: packages/browser-integration-tests
+        env:
+          CHANGED_TEST_PATHS: ${{ steps.changed.outputs.browser_integration_files }}
+          # Run 100 times when detecting changed test(s), else run all tests 5x
+          TEST_RUN_COUNT: ${{ steps.changed.outputs.browser_integration == 'true' && 100 || 5 }}

CHANGELOG.md

@@ -4,6 +4,43 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 7.44.0
+
+This release introduces the first alpha version of `@sentry/sveltekit`, our newest JavaScript SDK for Sveltekit. Check out the [README](./packages/sveltekit/README.md) for usage instructions and what to expect from this alpha release.
+
+- feat(replay): Add `request_body_size` & `response_body_size` to fetch/xhr (#7407)
+- feat(replay): Add additional properties for UI clicks (#7395)
+- feat(replay): Reduce time limit before pausing a recording (#7356)
+- feat(replay): Upgrade `rrweb` and `rrweb-player` (#7508)
+- feat(replay): Use new afterSend hook to improve error linking (#7390)
+- feat(serverless): Publish lambda layer for Node 16/18 (#7483)
+- feat(sveltekit): Add wrapper for client load function (#7447)
+- feat(sveltekit): Add wrapper for server load function (#7416)
+- feat(sveltekit): Add server-side `handleError` wrapper (#7411)
+- feat(sveltekit): Introduce client-side `handleError` wrapper (#7406)
+- feat(sveltekit): Add SvelteKit client and server `init` functions (#7408)
+- feat(sveltekit): Inject `Sentry.init` calls into server and client bundles (#7391)
+- feat(tracing): Expose `BrowserTracing` in non-tracing bundles (#7479)
+- fix(core): Permanent idle timeout cancel finishes the transaction with the last finished child
+- fix(integrations): Handle lower-case prefix windows paths in `RewriteFrames` (#7506)
+- fix(next): Guard against missing serverSideProps (#7517)
+- fix(nextjs): Fix broken server component wrapping because of interrupted promise chain (#7456)
+- fix(nextjs): Fix runtime error for static pages (#7476)
+- fix(profiling): Catch sendProfile rejection (#7446)
+- fix(replay): Never capture file input changes (#7485)
+- fix(serverless): Explicitly export node package exports (#7457)
+- fix(vue): Do not depend on `window.location` for SSR environments (#7518)
+
+
+**Replay `rrweb` changes:**
+
+`@sentry-internal/rrweb` was updated from 1.105.0 to 1.106.0:
+
+- feat: Ensure password inputs are always masked ([#78](https://github.com/getsentry/rrweb/pull/78))
+- fix: Ensure text masking for updated attributes works ([#83](https://github.com/getsentry/rrweb/pull/83))
+- fix: Ensure unmaskTextSelector is used for masked attributes ([#81](https://github.com/getsentry/rrweb/pull/81))
+- fix: Mask <option> values for selects & radio/checkbox value ([#75](https://github.com/getsentry/rrweb/pull/75))
+
 ## 7.43.0
 
 - feat(nextjs): Run source map upload in Vercel develop and preview environments (#7436)

CONTRIBUTING.md

@@ -33,6 +33,15 @@ Since we are using [`TypeScript`](https://www.typescriptlang.org/), you need to
 - `yarn build:dev:filter <name of npm package>`, which runs `yarn build:dev` only in projects relevant to the given package (so, for example, running `yarn build:dev:filter @sentry/react` will build the `react` package, all of its dependencies (`utils`, `core`, `browser`, etc), and all packages which depend on it (currently `gatsby` and `nextjs`))
 - `yarn build:dev:watch`, which runs `yarn build:dev` in watch mode (recommended)
 
+
+## Testing SDK Packages Locally
+
+To test local versions of SDK packages, for instance in test projects, you have a couple of options:
+
+* Use [`yarn link`](https://classic.yarnpkg.com/lang/en/docs/cli/link/) to symlink your package to the test project.
+* Use [`yalc` to install SDK packages](./docs/using-yalc.md) as if they were already published.
+* Run `build:tarball` in the repo and `yarn add ./path/to/tarball.tgz` in the project.
+
 ## Adding Tests
 
 **Any nontrivial fixes/features should include tests.** You'll find a `test` folder in each package.

docs/using-yalc.md

@@ -0,0 +1,51 @@
+# Using `yalc` for Local SDK Testing
+
+[Yalc](https://github.com/wclr/yalc) is a simple local dependency repository which we can use to work with local versions of our SDKs.
+This is a good alternative to `npm|yarn link` for packages where linking is problematic (e.g. SvelteKit or Angular).
+
+Here's how to set up and use yalc:
+
+## Installing `yalc`
+
+Either install yalc globally,
+
+```sh
+npm install -g yalc
+
+yarn global add yalc
+```
+
+or add it to your desired test projects (same command without the `-g|global` flags)
+
+## Registering/Updating packages
+
+Whenever you want to make your local changes available to your test projects (e.g. after a local code change), run:
+
+```sh
+yarn yalc:publish
+```
+
+If you run this command in the root of the repo, this will publish all SDK packages to the local yalc repo. If you run it in a specific SDK package, it will just publish this package. You **don't need to** call `yalc update` in your test project. Already linked test projects will be update automatically.
+
+## Using yalc packages
+
+In your test project, run
+
+```sh
+yalc add @sentry/browser #or any other SDK package
+```
+
+to add the local SDK package to your project.
+
+**Important:** You need to `yalc add` the dependencies of the SDK package as well (e.g. core, utils, types, etc.).
+
+## Troubleshooting:
+
+### My changes are not applied to the test project
+
+Did you run `yarn build && yarn publish:yalc` after making your changes?
+
+### My test project uses Vite and I still don't see changes
+
+Vite pre-bundles and caches dependencies for dev builds. It [doesn't recognize changes in yalc packages though](https://github.com/wclr/yalc/issues/189) :( To make these changes show up anyway, run `vite dev --force`.
+

package.json

@@ -12,11 +12,11 @@
     "build:types:watch": "ts-node scripts/build-types-watch.ts",
     "build:tarball": "lerna run build:tarball",
     "circularDepCheck": "lerna run circularDepCheck",
-    "clean": "run-p clean:build clean:caches",
+    "clean": "run-s clean:build clean:caches",
     "clean:build": "lerna run clean",
     "clean:caches": "yarn rimraf eslintcache .nxcache && yarn jest --clearCache",
     "clean:deps": "lerna clean --yes && rm -rf node_modules && yarn",
-    "clean:all": "run-p clean:build clean:caches clean:deps",
+    "clean:all": "run-s clean:build clean:caches clean:deps",
     "codecov": "codecov",
     "fix": "lerna run fix",
     "changelog": "ts-node ./scripts/get-commit-list.ts",
@@ -28,7 +28,8 @@
     "test:unit": "lerna run --ignore @sentry-internal/* test:unit",
     "test-ci-browser": "lerna run test --ignore \"@sentry/{node,opentelemetry-node,serverless,nextjs,remix,gatsby}\" --ignore @sentry-internal/*",
     "test-ci-node": "ts-node ./scripts/node-unit-tests.ts",
-    "test:update-snapshots": "lerna run test:update-snapshots"
+    "test:update-snapshots": "lerna run test:update-snapshots",
+    "yalc:publish": "lerna run yalc:publish"
   },
   "volta": {
     "node": "16.19.0",
@@ -38,15 +39,16 @@
     "packages/angular",
     "packages/angular-ivy",
     "packages/browser",
+    "packages/browser-integration-tests",
     "packages/core",
     "packages/e2e-tests",
     "packages/ember",
     "packages/eslint-config-sdk",
     "packages/eslint-plugin-sdk",
     "packages/gatsby",
     "packages/hub",
-    "packages/integration-tests",
     "packages/integrations",
+    "packages/integration-shims",
     "packages/overhead-metrics",
     "packages/nextjs",
     "packages/node",
@@ -60,6 +62,7 @@
     "packages/svelte",
     "packages/sveltekit",
     "packages/tracing",
+    "packages/tracing-internal",
     "packages/types",
     "packages/typescript",
     "packages/utils",
@@ -81,6 +84,7 @@
     "@types/node": "~10.17.0",
     "@types/rimraf": "^3.0.2",
     "@types/sinon": "^7.0.11",
+    "@vitest/coverage-c8": "^0.29.2",
     "acorn": "^8.7.0",
     "chai": "^4.1.2",
     "codecov": "^3.6.5",
@@ -93,7 +97,6 @@
     "karma-firefox-launcher": "^1.1.0",
     "lerna": "6.5.0-alpha.2",
     "madge": "4.0.2",
-    "magic-string": "^0.27.0",
     "mocha": "^6.1.4",
     "nodemon": "^2.0.16",
     "npm-run-all": "^4.1.5",
@@ -112,7 +115,9 @@
     "ts-node": "10.9.1",
     "tslib": "^2.3.1",
     "typedoc": "^0.18.0",
-    "typescript": "3.8.3"
+    "typescript": "3.8.3",
+    "vitest": "^0.29.2",
+    "yalc": "^1.0.0-pre.53"
   },
   "resolutions": {
     "**/agent-base": "5"

packages/angular-ivy/package.json

@@ -56,7 +56,8 @@
     "fix:prettier": "prettier --write \"{src,test,scripts}/**/**.ts\"",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --format stylish",
-    "lint:prettier": "prettier --check \"{src,test,scripts}/**/**.ts\""
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/**.ts\"",
+    "yalc:publish": "ts-node ../../scripts/prepack.ts && yalc publish build --push"
   },
   "volta": {
     "extends": "../../package.json"

packages/angular/package.json

@@ -59,7 +59,8 @@
     "lint:prettier": "prettier --check \"{src,test,scripts}/**/**.ts\"",
     "test": "yarn test:unit",
     "test:unit": "jest",
-    "test:unit:watch": "jest --watch"
+    "test:unit:watch": "jest --watch",
+    "yalc:publish": "ts-node ../../scripts/prepack.ts && yalc publish build --push"
   },
   "volta": {
     "extends": "../../package.json"

packages/integration-tests/.eslintrc.js → packages/browser-integration-tests/.eslintrc.js

@@ -4,7 +4,7 @@ module.exports = {
     node: true,
   },
   extends: ['../../.eslintrc.js'],
-  ignorePatterns: ['suites/**/subject.js', 'suites/**/dist/*'],
+  ignorePatterns: ['suites/**/subject.js', 'suites/**/dist/*', 'scripts/**'],
   parserOptions: {
     sourceType: 'module',
   },

packages/integration-tests/package.json → packages/browser-integration-tests/package.json

@@ -28,7 +28,8 @@
     "test:cjs": "PW_BUNDLE=cjs yarn test",
     "test:esm": "PW_BUNDLE=esm yarn test",
     "test:ci": "playwright test ./suites --browser='all' --reporter='line'",
-    "test:update-snapshots": "yarn test --update-snapshots --browser='all' && yarn test --update-snapshots"
+    "test:update-snapshots": "yarn test --update-snapshots --browser='all' && yarn test --update-snapshots",
+    "test:detect-flaky": "ts-node scripts/detectFlakyTests.ts"
   },
   "dependencies": {
     "@babel/preset-typescript": "^7.16.7",
@@ -40,6 +41,10 @@
     "typescript": "^4.5.2",
     "webpack": "^5.52.0"
   },
+  "devDependencies": {
+    "glob": "8.0.3",
+    "@types/glob": "8.0.0"
+  },
   "volta": {
     "extends": "../../package.json"
   }