Skip to content

feat(browser): Re-export addTracingExtensions from @sentry/core #7498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 17, 2023

This was missed off of #7472.

We should re-export addTracingExtensions so that users can enable tracing features without needing to use BrowserTracing:

import * as Sentry from '@sentry/browser';

Sentry.addTracingExtensions();

Sentry.init({
  dsn: "__DSN__",
  tracesSampleRate: 1.0,
});

Perhaps we should display a warning if users supply tracesSampleRate without first calling addTracingExtensions?

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should display a warning if users supply tracesSampleRate without first calling addTracingExtensions?

I think this is not necessary for now, we can add this if users come and complain a lot.

@AbhiPrasad AbhiPrasad merged commit c271767 into getsentry:develop Mar 17, 2023
@timfish timfish deleted the feat/browser/addTracingExtensions branch March 17, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants