feat(tracing): Move registerErrorInstrumentation
to @sentry/core
#7494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addTracingExtensions
in@sentry/core
feels like our better named replacement foraddExtensionMethods
however it didn't end up with the same functionality.While working on other tracing PRs I realised that we'd not moved
registerErrorInstrumentation
to core and it makes more sense for it to be there.This PR moves
registerErrorInstrumentation
to@sentry/core
and calls it fromaddTracingExtensions
since they are called together inaddExtensionMethods
. It also adds a flag so errors are only instrumented once. This means we can safely calladdTracingExtensions
as many times as we like (ie. from integration constructors, etc).