Skip to content

fix(replay): Never capture file input changes #7485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2023
Merged

fix(replay): Never capture file input changes #7485

merged 2 commits into from
Mar 20, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 16, 2023

IMHO we can just ignore all change events for file inputs, that should be OK I'd say?

Closes getsentry/rrweb#80

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Mar 16, 2023
@mydea mydea requested a review from billyvg March 16, 2023 13:13
@mydea mydea self-assigned this Mar 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.46 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 63.38 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.07 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.43 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.65 KB (0%)
@sentry/browser - Webpack (minified) 71.97 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.68 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.02 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 33.75 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.1 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.87 KB (+0.03% 🔺)
@sentry/replay - Webpack (gzipped + minified) 37.95 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.07 KB (+0.03% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.14 KB (+0.03% 🔺)

@mydea mydea force-pushed the fn/replay-ignore-files branch 2 times, most recently from 0ec91e1 to b46d648 Compare March 16, 2023 14:40
billyvg
billyvg approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mydea mydea force-pushed the fn/replay-ignore-files branch from b46d648 to 19226e7 Compare March 17, 2023 07:58
@mydea mydea force-pushed the fn/replay-ignore-files branch from 19226e7 to 7ae28fe Compare March 17, 2023 13:22
@mydea mydea merged commit 86cd7fd into develop Mar 20, 2023
@mydea mydea deleted the fn/replay-ignore-files branch March 20, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mutations are capturing file uploads
2 participants
@mydea @billyvg