-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(replay): Use new afterSend hook to improve error linking #7390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5f709f7
feat(replay): Use new afterSend hook to improve error linking
mydea 3e6bd4f
ref: Make hook` afterSendEvent`
mydea 5030d40
use force flush test util
mydea 27f00ed
extract callback type to top
mydea 1c45239
fix lint
mydea dc576da
make less brittle
mydea 1219f4d
Apply suggestions from code review
mydea 21bd94c
add comment for afterSendHandler
mydea 569b645
move tests to new dir
mydea 1d97cde
fix test
mydea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
packages/browser-integration-tests/suites/replay/errors/errorModeCustomTransport/init.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import * as Sentry from '@sentry/browser'; | ||
|
||
window.Sentry = Sentry; | ||
window.Replay = new Sentry.Replay({ | ||
flushMinDelay: 500, | ||
flushMaxDelay: 500, | ||
}); | ||
|
||
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
sampleRate: 1, | ||
replaysSessionSampleRate: 0.0, | ||
replaysOnErrorSampleRate: 1.0, | ||
integrations: [window.Replay], | ||
transport: options => { | ||
const transport = new Sentry.makeXHRTransport(options); | ||
|
||
delete transport.send.__sentry__baseTransport__; | ||
|
||
return transport; | ||
}, | ||
}); |
42 changes: 42 additions & 0 deletions
42
packages/browser-integration-tests/suites/replay/errors/errorModeCustomTransport/test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import { expect } from '@playwright/test'; | ||
|
||
import { sentryTest } from '../../../../utils/fixtures'; | ||
import { getReplaySnapshot, shouldSkipReplayTest, waitForReplayRequest } from '../../../../utils/replayHelpers'; | ||
|
||
sentryTest( | ||
'[error-mode] should handle errors with custom transport', | ||
async ({ getLocalTestPath, page, forceFlushReplay }) => { | ||
if (shouldSkipReplayTest()) { | ||
sentryTest.skip(); | ||
} | ||
|
||
const promiseReq0 = waitForReplayRequest(page, 0); | ||
const promiseReq1 = waitForReplayRequest(page, 1); | ||
|
||
let callsToSentry = 0; | ||
|
||
await page.route('https://dsn.ingest.sentry.io/**/*', route => { | ||
callsToSentry++; | ||
|
||
return route.fulfill({ | ||
// Only error out for error, then succeed | ||
status: callsToSentry === 1 ? 422 : 200, | ||
}); | ||
}); | ||
|
||
const url = await getLocalTestPath({ testDir: __dirname }); | ||
|
||
await page.goto(url); | ||
await forceFlushReplay(); | ||
expect(callsToSentry).toEqual(0); | ||
|
||
await page.click('#error'); | ||
await promiseReq0; | ||
|
||
await forceFlushReplay(); | ||
await promiseReq1; | ||
|
||
const replay = await getReplaySnapshot(page); | ||
expect(replay.recordingMode).toBe('session'); | ||
}, | ||
); |
15 changes: 15 additions & 0 deletions
15
packages/browser-integration-tests/suites/replay/errors/errorNotSent/init.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import * as Sentry from '@sentry/browser'; | ||
|
||
window.Sentry = Sentry; | ||
window.Replay = new Sentry.Replay({ | ||
flushMinDelay: 500, | ||
flushMaxDelay: 500, | ||
}); | ||
|
||
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
sampleRate: 1, | ||
replaysSessionSampleRate: 0.0, | ||
replaysOnErrorSampleRate: 1.0, | ||
integrations: [window.Replay], | ||
}); |
41 changes: 41 additions & 0 deletions
41
packages/browser-integration-tests/suites/replay/errors/errorNotSent/test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
import { expect } from '@playwright/test'; | ||
|
||
import { sentryTest } from '../../../../utils/fixtures'; | ||
import { getReplaySnapshot, shouldSkipReplayTest } from '../../../../utils/replayHelpers'; | ||
|
||
sentryTest( | ||
'[error-mode] should handle errors that result in API error response', | ||
async ({ getLocalTestPath, page, forceFlushReplay }) => { | ||
if (shouldSkipReplayTest()) { | ||
sentryTest.skip(); | ||
} | ||
|
||
let callsToSentry = 0; | ||
|
||
await page.route('https://dsn.ingest.sentry.io/**/*', route => { | ||
callsToSentry++; | ||
|
||
return route.fulfill({ | ||
status: 422, | ||
contentType: 'application/json', | ||
}); | ||
}); | ||
|
||
const url = await getLocalTestPath({ testDir: __dirname }); | ||
|
||
await page.goto(url); | ||
await forceFlushReplay(); | ||
expect(callsToSentry).toEqual(0); | ||
|
||
await page.click('#error'); | ||
|
||
await page.click('#log'); | ||
await forceFlushReplay(); | ||
|
||
// Only sent once, but since API failed we do not go into session mode | ||
expect(callsToSentry).toEqual(1); | ||
|
||
const replay = await getReplaySnapshot(page); | ||
expect(replay.recordingMode).toBe('error'); | ||
}, | ||
); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.