feat(replay): Consider user input in form field as "user activity" #7355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds user input (event from core SDK) as a trigger for user activity (to reset idle timeout). Note that this is only from input changes in a form field, it will not consider using tab key to move focus.
size-limit report 📦
|
mydea
reviewed
Mar 7, 2023
| @@ -12,7 +12,7 @@ export function addBreadcrumbEvent(replay: ReplayContainer, breadcrumb: Breadcru | |||
| return; | |||
| } | |||
|
|
|||
| if (breadcrumb.category === 'ui.click') { | |||
| if (['ui.click', 'ui.input'].includes(breadcrumb.category || '')) { | |||
There was a problem hiding this comment.
l: IMHO we do not need the || '' part, it should still work with includes(undefined) - we can safe some bytes by doing includes(breadcrumb.category as string) (to satisfy TS)?
mydea
approved these changes
Mar 7, 2023
AbhiPrasad
pushed a commit
that referenced
this pull request
Mar 8, 2023
…7355) This adds user input (event from core SDK) as a trigger for user activity (to reset idle timeout). Note that this is only from input changes in a form field, it will not consider using tab key to move focus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds user input (event from core SDK) as a trigger for user activity (to reset idle timeout). Note that this is only from input changes in a form field, it will not consider using tab key to move focus.