fix(nextjs): Exclude SDK from Edge runtime bundles #6683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
force-pushed
the
lforst-exclude-sentry-from-edge-runtime-bundles
branch
from
3a307cf to
ec34a01
Compare
AbhiPrasad
approved these changes
Jan 9, 2023
| isServer, | ||
| userSentryOptions.excludeServerRoutes, | ||
| isDev, | ||
| buildContext.nextRuntime === 'edge', |
There was a problem hiding this comment.
l: Only thing I'd like to see here is the equality check extracted into a helper func, but nbd.
Honestly, I thought the exact same thing while making this change. Let me see if I can somehow clean this up a bit without too much effort, otherwise, I'll do it in a follow-up soon. |
size-limit report 📦
|
|
Ok I think this is hopeless. This file needs a major refactoring. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #6120
Builds currently emit warnings when there is a route using the Vercel edge runtime because we are injecting code into the serverless bundles that is using APIs that are not WinterCG compatible or we are wrapping with code that uses server SDK functions even though we are injecting the client SDK.
Also resolves #5974