feat(replay): Use new prepareEvent util & ensure dropping replays works
#6522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/prepareEvent-use-replay
branch
from
29a7213 to
9521386
Compare
mydea
force-pushed
the
fn/prepareEvent-use-replay
branch
from
9521386 to
8aaff54
Compare
Lms24
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Nice work! I'm a little concerned about the bundle size increase though... my guess is that we now bundle prepareEvent into the Replay CDN bundle which causes this increase. I guess we'll just have to take that hit but this def adds to the benefits of a complete bundle (#6573).
| @@ -108,7 +108,6 @@ export function makeTerserPlugin() { | |||
| '_initStorage', | |||
| '_support', | |||
| // TODO: Get rid of these once we use the SDK to send replay events | |||
| '_prepareEvent', // replay uses client._prepareEvent | |||
| '_metadata', // replay uses client.getOptions()._metadata | |||
There was a problem hiding this comment.
Side-note: As discussed, I'll take a look if we can get rid of the _metadata entry here
mydea
force-pushed
the
fn/prepareEvent-use-replay
branch
from
8aaff54 to
7fecdfb
Compare
mydea
force-pushed
the
fn/prepareEvent-use-replay
branch
from
7fecdfb to
c2ba7be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on #6517
This uses the newly exposed
prepareEventutil from core, and also makes sure that the event processors actually work as expected.General changes:
null(previously, this would error)