Skip to content

ref(replay): Stop calling _updateSessionFromEvent #6510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2022
Merged

ref(replay): Stop calling _updateSessionFromEvent #6510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/event-sending.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ This document gives an outline for how event sending works, and which which plac
* `baseclient._applyIntegrationsMetadata()`
* `scope.applyToEvent()`
* `baseclient._normalizeEvent()`
* `baseclient._updateSessionFromEvent()`
* `createReplayEnvelope()`
* `createEnvelope()`
* `transport.send()`
Expand Down
6 changes: 0 additions & 6 deletions packages/replay/src/util/getReplayEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ export async function getReplayEvent({
// @ts-ignore private api
const preparedEvent: Event = await client._prepareEvent(event, { event_id }, scope);

const session = scope && scope.getSession();
if (session) {
// @ts-ignore private api
client._updateSessionFromEvent(session, preparedEvent);
}

preparedEvent.sdk = {
...preparedEvent.sdk,
...REPLAY_SDK_INFO,
Expand Down
1 change: 0 additions & 1 deletion rollup/plugins/bundlePlugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ export function makeTerserPlugin() {
'_support',
// TODO: Get rid of these once we use the SDK to send replay events
'_prepareEvent', // replay uses client._prepareEvent
'_updateSessionFromEvent', // replay client._updateSessionFromEvent
],
},
},
Expand Down