feat(types): Upstream some replay types #6506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
added
Package: types
Package: replay
size-limit report 📦
|
billyvg
reviewed
Dec 13, 2022
packages/replay/src/replay.ts
Outdated
| @@ -942,6 +942,7 @@ export class ReplayContainer implements ReplayContainerInterface { | |||
| trace_ids: traceIds, | |||
| urls, | |||
| replay_id: replayId, | |||
| event_id: replayId, | |||
There was a problem hiding this comment.
I don't think this is what we want as we will then have multiple replay events with the same event id?
There was a problem hiding this comment.
I think we can get of this line, right? The uuid is assigned in _prepareEvent.
billyvg
reviewed
Dec 13, 2022
Comment on lines
+137
to
+191
| replay_event: 'replay_event', | ||
| replay_recording: 'replay_recording', |
There was a problem hiding this comment.
damn we should have named these replay and recording to be consistent with our other event types
Lms24
reviewed
Dec 13, 2022
Lms24
approved these changes
Dec 13, 2022
mydea
force-pushed
the
fn/replay-types
branch
from
a345409 to
8a6a338
Compare
billyvg
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upstreams some types from
@sentry/replayto@sentry/types, in preparation for moving some stuff there.Especially the
ReplayEventmay still change a bit, but I think this should be fine.