-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(core): Add replay_event
type for events
#6481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -233,7 +233,7 @@ export class Hub implements HubInterface { | |||||||||||||||||||||||||||||
*/ | ||||||||||||||||||||||||||||||
public captureEvent(event: Event, hint?: EventHint): string { | ||||||||||||||||||||||||||||||
const eventId = hint && hint.event_id ? hint.event_id : uuid4(); | ||||||||||||||||||||||||||||||
if (event.type !== 'transaction') { | ||||||||||||||||||||||||||||||
if (!event.type) { | ||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question: I guess replays should not count here? (Eventually - currently they do not go through this method at all) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reading #3966, I think you're right. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We might also add a test for the new event type here: sentry-javascript/packages/hub/test/hub.test.ts Lines 360 to 373 in c68d429
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done in 37535a0 |
||||||||||||||||||||||||||||||
this._lastEventId = eventId; | ||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To note, this is technically correct, but may increase the bundle size slightly for "nothing", as this will not really be hit right now. I'd still rather leave this in and remove it once we (hopefully soon!) actually handle replay events "normally". WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.