Skip to content

ref: Drop no-plusplus rule & refactor to use ++ / -- #6327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 29, 2022

This PR removes the no-plusplus eslint rule, as it doesn't really apply to us. By replacing usage of a += 1 with a++, and a -= 1 with a-- we should actually be able to shave a few bytes off our bundles.

@mydea mydea requested a review from a team November 29, 2022 11:22
@mydea mydea self-assigned this Nov 29, 2022
@mydea mydea requested review from lobsterkatie and AbhiPrasad and removed request for a team November 29, 2022 11:22
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.53 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.42 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.21 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.76 KB (-0.02% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.94 KB (+0.01% 🔺)
@sentry/browser - Webpack (minified) 65.25 KB (-0.02% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.96 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.96 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.41 KB (-0.03% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.83 KB (-0.01% 🔽)
@sentry/replay index.js 83.65 KB (-0.07% 🔽)
@sentry/replay - Webpack (gzipped + minified) 83.67 KB (-0.07% 🔽)
@sentry/replay - Webpack (minified) 272.53 KB (-0.06% 🔽)

@mydea mydea merged commit c6f9dfe into master Nov 29, 2022
@mydea mydea deleted the fn/drop-no-plusplus-rule branch November 29, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants