Don't additionally pass msg if exception interface set #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Raven._processException(undefined, '\'foo\' is undefined', 'http://example.com', 10); // IE9 ReferenceError | ||
| assert.deepEqual(Raven._send.lastCall.args[0].message, '\'foo\' is undefined'); | ||
| }); |
There was a problem hiding this comment.
I removed this because I felt this test had no application any longer now that we were not additionally storing message for exceptions.
| // Fire away! | ||
| this._send( | ||
| objectMerge({ | ||
| message: msg + '' // Make sure it's actually a string | ||
| message: msg, |
There was a problem hiding this comment.
Why did this change? And also introduced a trailing comma. I think that's still a bad thing?
There was a problem hiding this comment.
@mattrobenolt AFAIK for IE 8 it is, yes
There was a problem hiding this comment.
I just moved it up higher (and kept the comment)
There was a problem hiding this comment.
Mmm, in hindsight, I probably did this because in some version I did something else with msg so I wanted the conversion higher. I'll just restore this code.
|
🆒 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the redundant "message" interface inside of the Sentry UI if an exception is passed. The message interface will appear if captured via
captureMessage/ no exception.cc @mattrobenolt @dcramer