-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(build): Remove constToVarPlugin
#5970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
…remove-const-to-var-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was initially more in favour of changing const->var to const->let which would have solved at least the two Vue-related issues we've talked about. However, seeing that there are a lot of advantages in removing this plugin entirely, I think we can live with the (as you said negligible) bundle size impact.
Also, great that this simplifies our testing setup!
This PR started out as an experiment but thinking more about this, I would actually go forward with this change, because:
const
withvar
causes actual problems (ui.vue application render is always cancelled #5917)global
and the ambient globalglobal
.I am open to discussing any drawbacks this might have! So far I don't really see any besides changes in bundle size.
Resolves #5925