test(e2e): Add behaviour test for Errors in standard React E2E tests application #5909
Conversation
| if (!fs.existsSync(authTokenPath)) { | ||
| fs.writeFileSync(authTokenPath, JSON.stringify({ authToken: authTokenHint }, null, 2)); | ||
| console.log( | ||
| 'No auth token configured for E2E tests! Please set the E2E_TEST_AUTH_TOKEN environment variable or put your auth token in "auth-token.json"!', |
There was a problem hiding this comment.
m: Why not just use a .env file? We can detect process.env.NODE_ENV is CI and fail fast if we don't see a .env configured.
There was a problem hiding this comment.
Yeah you're right. I totally overcomplicated this. Changed it to just use env vars all the way! 018bccc
| @@ -15,7 +15,8 @@ import Index from './pages/Index'; | |||
| import User from './pages/User'; | |||
|
|
|||
| Sentry.init({ | |||
| dsn: 'https://[email protected]/1337', | |||
| // DSN belongs to "e2e-javascript-standard-frontend-react" project in "sentry-sdks" org | |||
| dsn: 'https://[email protected]/4503941750587392', | |||
There was a problem hiding this comment.
l: Should we inject this instead of hardcoding?
m: Also, I'd rather just send everything to one project (not specify it to react), we can use sdk name/version to filter it in the Sentry UI.
There was a problem hiding this comment.
Thinking more about it I agree. Changed it so we're injecting the DSN via env var: 018bccc
lforst
force-pushed
the
lforst-standard-react-application-behaviour-e2e-test
branch
from
64146e7 to
018bccc
Compare
| } | ||
|
|
||
| const envVarsToInject = { | ||
| REACT_APP_E2E_TEST_DSN: process.env.E2E_TEST_DSN, |
There was a problem hiding this comment.
Why do we do the renaming here? Shouldn't it just be called E2E_TEST_DSN everywhere?
There was a problem hiding this comment.
Since CRA apps are static we need to inject the DSN during build time (I guess that's more or less only possible with env vars) and CRA has restrictions on what env vars may look like: https://create-react-app.dev/docs/adding-custom-environment-variables/ (They only allow env vars prefixed with REACT_APP_)
| @@ -0,0 +1 @@ | |||
| .env | |||
There was a problem hiding this comment.
l: should we add an .env.example?
lforst
deleted the
lforst-standard-react-application-behaviour-e2e-test
branch
Ref: #5855
Introduces a behaviour test in the
standard-frontend-reactE2E tests. This test triggers an error in the application using Playwright and verifies if an error event was sent to Sentry by polling for the event via the Sentry API.We also jump through some hoops to inject the auth token required for polling Sentry into the test. It's so that we can configure the auth token either via an env var or via a file.
Next up we will verify the behaviour of transactions and sessions in additional tests: #5912