Skip to content

chore(deps): Upgrade @embroider/macros #5769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

dagroe
Copy link
Contributor

@dagroe dagroe commented Sep 19, 2022

Upgrade @embroider/macros as an attempt to fix #5701

@AbhiPrasad AbhiPrasad requested a review from k-fish September 19, 2022 08:59
@dagroe dagroe force-pushed the upgrade-embroider-macros branch from e7815fa to 87d0b7f Compare September 19, 2022 09:10
@@ -29,7 +29,7 @@
"test:all": "node ./scripts/run-CI-tests.js"
},
"dependencies": {
"@embroider/macros": "~0.47.2",
"@embroider/macros": "1.8.3",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be ^1.8.3 similar to what @ember-data/model has as dependency? https://github.com/emberjs/data/blob/master/packages/model/package.json#L30

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine leaving it exact, we have a lock anyway.

@AbhiPrasad AbhiPrasad added the Package: ember Issues related to the Sentry Ember SDK label Sep 19, 2022
Copy link
Member

@k-fish k-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a shot 👍

@k-fish k-fish merged commit 1540616 into getsentry:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: ember Issues related to the Sentry Ember SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sentry/ember breaks ember-cli build when used with ember-data >= 4.6.1
4 participants