fix: Always use ? for anonymous function name
#5664
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
force-pushed
the
fix/normalize-anon-fn-to-question-mark
branch
from
278b227 to
6c22fa5
Compare
|
Abhi has marked this for v8.0.0 since this is technically a breaking change |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
@timfish let's close this to clean up the PRs stream, but we should re-open and merge once v8 is ready. |
AbhiPrasad
pushed a commit
that referenced
this pull request
Feb 20, 2024
This was previously opened as #5664 but closed as it was a breaking change. Now that we're getting ready to ship, v8 this is viable!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5523
This moves the
'?'string to@sentry/utilsso it only exists once in the bundle.