fix(remix): Make peer deps less restrictive #5369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
lforst and
Lms24
and removed request for
a team
|
Do we know for sure that the SDK works with versions of remix between 1.0.0 and 1.4.3? |
|
@onurtemizkan will have the most context, but afaik all the APIs we wrap have been there since the |
|
I didn't test below |
|
All right - let's do it, then. If it breaks horribly for older versions, I'm sure someone will tell us about it. 😛 |
lobsterkatie
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was dogfooding remix on https://github.com/getsentry/vanguard, I realized the remix peer deps are pretty restrictive. This opens it up so that we at least support
1.xof remix - we can re-evaluate when a new major comes out!