Skip to content

fix(tracing): Report the right units for CLS and TTFB [INGEST-1409] #5303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2022
Merged

fix(tracing): Report the right units for CLS and TTFB [INGEST-1409] #5303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86eb902
fix: Report the right units for CLS and TTFB
untitaker Jun 23, 2022
5451284
Update packages/tracing/src/browser/metrics/index.ts
untitaker Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/tracing/src/browser/metrics/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function _trackCLS(): void {
}

__DEBUG_BUILD__ && logger.log('[Measurements] Adding CLS');
_measurements['cls'] = { value: metric.value, unit: 'millisecond' };
_measurements['cls'] = { value: metric.value, unit: 'none' };
_clsEntry = entry as LayoutShift;
});
}
Expand Down Expand Up @@ -172,7 +172,7 @@ export function addPerformanceEntries(transaction: Transaction): void {
// This is the time between the start of the request and the start of the response in milliseconds.
_measurements['ttfb.requestTime'] = {
value: (responseStartTimestamp - requestStartTimestamp) * 1000,
unit: 'second',
unit: 'millisecond',
};
}
}
Expand Down