ref(node): Explicitly pass down node transport options #5057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We enforce the transport types by assigning the generic when typing the Node Client class (we use `ClientOptions<NodeTransportOptions>`). To further refine the transport types, we remove the transport options from the top level of the sdk init and instead require users to pass it in under the `transportOptions` key explicitly.
AbhiPrasad
force-pushed
the
v7-abhi-node-transport-options
branch
from
2802762 to
7f089d4
Compare
size-limit report 📦
|
lforst
approved these changes
May 10, 2022
AbhiPrasad
added a commit
that referenced
this pull request
May 30, 2022
We enforce the transport types by assigning the generic when typing the Node Client class (we use `ClientOptions<NodeTransportOptions>`). To further refine the transport types, we remove the transport options from the top level of the sdk init and instead require users to pass it in under the `transportOptions` key explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enforce the transport types by assigning the generic when typing the
Node Client class (we use
ClientOptions<NodeTransportOptions>).To further refine the transport types, we remove the transport options
from the top level of the sdk init and instead require users to pass it
in under the
transportOptionskey explicitly.Resolves https://getsentry.atlassian.net/browse/WEB-914