chore(various): Autoformat JS files #4726
Conversation
lobsterkatie
force-pushed
the
kmclb-autoformat-js-files-march-2022
branch
from
2de701f to
bd319d4
Compare
lobsterkatie
force-pushed
the
kmclb-autoformat-js-files-march-2022
branch
2 times, most recently
from
8a5ecfe to
0251b73
Compare
size-limit report
|
| nock('http://example.com') | ||
| .get('/') | ||
| .reply(200, 'ok'); | ||
| nock('http://example.com').get('/').reply(200, 'ok'); |
There was a problem hiding this comment.
This is interesting to me. Are we fine with that change? I might be wrong but to me it seems like this chain was spread over multiple lines on purpose. There are some similar reformats with arguments, array contents, etc. which were also reformatted to a single line.
I'm not criticising the change itself and I know that argument/parameter wrapping and alignment is hard to define properly for every situation but I just wanted to highlight that this might be an unintended format change. Nevertheless, I think consistency is important so I'd be totally on board with the change.
There was a problem hiding this comment.
I actually happen to agree with you that it's easier to read on multiple lines. That said, it's not up to us, or at least, as long as we're using Prettier it's not - it will make the change whether we want it to or not (and that's not configurable - see below). And since we format on save, trying to keep it in a different state than Prettier wants it is ultimately a losing game. (I know, I've tried!) This PR just keeps those inevitable changes from ending up in unrelated PRs because someone happens to have touched one of these files and hit 'save.'
Here's Prettier's take on why it should get to choose:
https://prettier.io/docs/en/why-prettier.html
https://prettier.io/docs/en/option-philosophy.html
There was a problem hiding this comment.
Okay, thanks for the links. They're an interesting read. So as I've said, the PR is looking good to me.
This applies the autoformatter to all of the JS (as in, written originally in JS, not transpiled into JS) files in the repo, to avoid having future changes to those files polluted by irrelevant autoformating triggered by saving the file. A few non-JS files, primarily in the ember package, are also included.