ref(browser): Simplify TraceKit parser and reorganize tests #4514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guessing these code analysis results are false positives since it's highlighting regexes that I haven't even modified? |
It might be that CodeQL only scans code that was changed (and tracekit regex hasn’t been moved for a while). I’ll mark as false positive for now. |
AbhiPrasad
changed the title
AbhiPrasad
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Seems to have ~0.7% difference in minified, non-gzipped bundle (which is what we are focusing on)
@sentry/browser - CDN Bundle (gzipped)
Size limit: 100 KB
Size: 19.63 KB with all dependencies, minified and gzipped
@sentry/browser - CDN Bundle (minified)
Size limit: 120 KB
Size: 62.75 KB with all dependencies and minified
@sentry/browser - Webpack
Size limit: 100 KB
Size: 22.16 KB with all dependencies, minified and gzipped
@sentry/browser - Webpack - gzip = false
Size limit: 100 KB
Size: 75.87 KB with all dependencies and minified
@sentry/react - Webpack
Size limit: 100 KB
Size: 22.19 KB with all dependencies, minified and gzipped
@sentry/nextjs Client - Webpack
Size limit: 100 KB
Size: 46.26 KB with all dependencies, minified and gzipped
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped)
Size limit: 100 KB
Size: 28.18 KB with all dependencies, minified and gzipped
|
I'm gonna tag @kamilogorek for a review for some added confidence. |
kamilogorek
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors and reorganises typekit unit tests:
messageandnamewhich were previously not checkedMakes a few simplifications to tracekit parser including:
argsaddress atstripping to the Chrome regexerror.columnNumbersince it's not used and even the original typekit tests expect what appears in the stack string