Skip to content

chore(nextjs): Add incremental option to nextjs integration test tsconfig #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lobsterkatie
Copy link
Member

Recently, nextjs started auto-defaulting the incremental tsconfig option (which caches certain information build to build) to true in nextjs projects using typescript, by modifying the projects' tsconfig files.

This incorporates that tsconfig change into the app we use for integration tests.

@lobsterkatie lobsterkatie enabled auto-merge (squash) December 7, 2021 19:28
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

size-limit report

Path Base Size (bb80135) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 22.45 KB 22.45 KB +0.01% 🔺
@sentry/browser - Webpack 23.29 KB 23.29 KB 0%
@sentry/react - Webpack 23.32 KB 23.32 KB 0%
@sentry/nextjs Client - Webpack 48.08 KB 48.08 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.99 KB 29.98 KB -0.01% 🔽

@lobsterkatie lobsterkatie merged commit 24b600f into master Dec 9, 2021
@lobsterkatie lobsterkatie deleted the kmclb-nextjs-add-incremental-in-integration-tests-tsconfig branch December 9, 2021 19:38
onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
…config (#4248)

Recently[1], nextjs started auto-defaulting the `incremental` tsconfig option[2] (which caches certain information build to build) to `true` in nextjs projects using typescript, by modifying the projects' `tsconfig` files.

This incorporates that `tsconfig` change into the app we use for integration tests.

[1] vercel/next.js#29169
[2] https://www.typescriptlang.org/tsconfig#incremental
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants