Skip to content

fix(angular): Finish routing span before starting another one #4191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

AbhiPrasad
Copy link
Member

No description provided.

@AbhiPrasad AbhiPrasad requested a review from k-fish November 29, 2021 18:35
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.49 KB (+0.01% 🔺)
@sentry/browser - Webpack 23.37 KB (0%)
@sentry/react - Webpack 23.4 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.93 KB (+0.01% 🔺)

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I'm the one affected by this: RDLGTM :)

Thanks @k-fish @AbhiPrasad

@AbhiPrasad AbhiPrasad merged commit af0e436 into master Nov 29, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-angular-routing branch November 29, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants