Skip to content

ref(browser): Streamline showReportDialog code #16339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

ref(browser): Streamline showReportDialog code #16339

merged 2 commits into from
May 20, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented May 20, 2025

Just a small refactor, noticed this while working on other browser sdk stuff. Moving this into a dedicated file decouples this from the core SDK functionality, which this IMHO is not (anymore). Also, we can streamline the code slightly for efficiency.

Just a small refactor, noticed this while working on other browser sdk stuff. Moving this into a dedicated file decouples this from the core SDK functionality, which this IMHO is not (anymore). Also, we can streamline the code slightly for efficiency.
@mydea mydea self-assigned this May 20, 2025
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.04 kB - -
@sentry/browser - with treeshaking flags 23.7 kB - -
@sentry/browser (incl. Tracing) 38.46 kB - -
@sentry/browser (incl. Tracing, Replay) 76.58 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.61 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 81.35 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 93.46 kB - -
@sentry/browser (incl. Feedback) 40.83 kB - -
@sentry/browser (incl. sendFeedback) 28.79 kB - -
@sentry/browser (incl. FeedbackAsync) 33.66 kB - -
@sentry/react 25.82 kB -0.18% -44 B 🔽
@sentry/react (incl. Tracing) 40.43 kB -0.13% -50 B 🔽
@sentry/vue 28.44 kB - -
@sentry/vue (incl. Tracing) 40.28 kB - -
@sentry/svelte 24.07 kB - -
CDN Bundle 25.24 kB -0.04% -8 B 🔽
CDN Bundle (incl. Tracing) 38.53 kB -0.03% -8 B 🔽
CDN Bundle (incl. Tracing, Replay) 74.31 kB -0.02% -8 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 79.76 kB -0.01% -6 B 🔽
CDN Bundle - uncompressed 73.63 kB -0.07% -50 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 114.03 kB -0.05% -50 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 228 kB -0.03% -50 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 240.82 kB -0.03% -50 B 🔽
@sentry/nextjs (client) 42.08 kB - -
@sentry/sveltekit (client) 38.95 kB - -
@sentry/node 158.16 kB - -
@sentry/node - without tracing 98.07 kB - -
@sentry/aws-serverless 123.41 kB - -

View base workflow run

@mydea mydea marked this pull request as ready for review May 20, 2025 09:58
@mydea mydea requested review from s1gr1d and andreiborza May 20, 2025 09:58
@mydea mydea merged commit 09e1cef into develop May 20, 2025
126 checks passed
@mydea mydea deleted the fn/showReport branch May 20, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants