-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test(node): Add pg-native
tests
#15465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70d3378
to
be9d8f4
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
e6c6922
to
51c7a58
Compare
Sorry for the delay reviewing this. I think approach is good. Do you mind rebasing this? |
51c7a58
to
19c8b5d
Compare
AbhiPrasad
approved these changes
Mar 18, 2025
20f755f
to
8450623
Compare
@AbhiPrasad, I rebased it. It's ready to go. |
8450623
to
d8c5262
Compare
d8c5262
to
d0e1fbd
Compare
dev-packages/node-integration-tests/suites/tracing/postgres/scenario.js
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the
pg
andpg-native
dependencies inside the test suite. This keepslibpq
out of the rootyarn.lock
.@AbhiPrasad, would this resolve the concerns in #15464?