Skip to content

test(e2e): Fix flake in default browser e2e test #13379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 14, 2024

This PR relaxes the pageload transaction assertion. Web vitals are too flaky to hard-assert on them and they are covered in browser integration tests

closes #13377

@Lms24 Lms24 self-assigned this Aug 14, 2024
@Lms24 Lms24 merged commit 7aebf94 into develop Aug 14, 2024
98 checks passed
@Lms24 Lms24 deleted the lms/test-fix-e2e-flake branch August 14, 2024 13:38
Zen-cronic pushed a commit to Zen-cronic/sentry-javascript that referenced this pull request Aug 26, 2024
relax the pageload transaction assertion. Web vitals are too
flaky to hard-assert on them and they are covered in browser integration
tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: browser default e2e test: web vital assertions cause flakes
2 participants